Editorial: describe isProofVerified's type more accurately.

w3c / vc-data-integrity

W3C Data Integrity Specification

https://w3c.github.io/vc-data-integrity/

Other

42 stars 19 forks source link

Editorial: describe isProofVerified's type more accurately. #235

Closed jyasskin closed 7 months ago

jyasskin commented 9 months ago

Fixing https://github.com/w3c/vc-data-integrity/pull/226#discussion_r1439881618.

Preview | Diff

msporny commented 7 months ago

This PR feels like it's been overtaken by PR #244, namely: https://pr-preview.s3.amazonaws.com/w3c/vc-data-integrity/pull/244.html#dfn-verification-result

@jyasskin, thoughts?

I know that PR #244 also changes the datatype and concept behind "isProofVerified" (which we still might not have alignment on), but does PR #244 capture the concerns you were trying to address in this PR? If so, we can close this PR in favor of #244.

jyasskin commented 7 months ago

Yes, there's no need to proceed with this PR.