w3c / vc-data-integrity

W3C Data Integrity Specification
https://w3c.github.io/vc-data-integrity/
Other
39 stars 17 forks source link

Wrong cryptosuite name in example #252

Closed iherman closed 2 months ago

iherman commented 4 months ago

Example 4 refers to ecdsa-2019 for cryptosuite (and there is also a reference to it in the preceding section). However, the ECDSA spec only defines ecdsa-rdfc-2019, ecdsa-jcs-2019, and ecdsa-sd-2023. I presume that in this case the right reference should be ecdsa-rdfc-2019.

I did not do an exhaustive search for the other references, there might be more such discrepancies.

iherman commented 4 months ago

There were only a few references to be changed after all: the two raised in the issue, plus a bbs-2023 (which was bbs-2022).

I have created a PRL #253. This issue can be closed if and when that PR is merged.

msporny commented 2 months ago

PR #253 has been merged, closing.