search

w3c / vc-data-integrity

W3C Data Integrity Specification
https://w3c.github.io/vc-data-integrity/
Other
42 stars 19 forks source link

Add discussion on putting `digestMultibase` in contexts. #264

Closed wes-smith closed 3 months ago

wes-smith commented 4 months ago

This PR attempts to address issue #241 by suggesting when to include digestMultibase in contexts.

Preview | Diff

wes-smith commented 4 months ago

Any way to force a recheck here? I connected my GitHub to my W3C account and a newer PR I raised doesn't have this issue, but this one doesn't seem to automatically update. I could make dummy commits but would prefer to avoid that.

wes-smith commented 4 months ago

@Wind4Greg fixed, thanks. A new commit also fixed the PR check.

iherman commented 4 months ago

Minor nits. The issue requested that digestMultibase be added to the DI context, but this PR doesn't do that. We'll either have to give a justification to the requestor, or add it.

This change, plus the fact that the term is in the VC context, works for me per the arguments of @dlongley. There is also a discussion elsewhere whether this document is the right place for the term to be, so I am fine merging and closing #241.

msporny commented 3 months ago

Editorial, multiple reviews, changes requested and made, no objections, merging.