w3c / vc-data-integrity

W3C Data Integrity Specification
https://w3c.github.io/vc-data-integrity/
Other
39 stars 17 forks source link

Update proof set/chain verification algorithm. #265

Closed wes-smith closed 1 month ago

wes-smith commented 1 month ago

This PR attempts to fix #260 by doing the following things:


Preview | Diff

wes-smith commented 1 month ago

@msporny added suggested changes to change the return type of the algorithm to include an array of successfully verified proofs as well as changes to update the names of the returned verificationResult properties to conform with the definition linked above.

msporny commented 1 month ago

@msporny added suggested changes to change the return type of the algorithm to include an array of successfully verified proofs as well as changes to update the names of the returned verificationResult properties to conform with the definition linked above.

Yes, better, though it's still not aligned and now I'm seeing that it probably could never be aligned because the VCDM presumes that you are only verifying a single proof at a time. We're going to have to loosen the interface language in VCDM, or we could just not care and say that verifying proof sets/chains is a different thing, outside of the base verification interface.

In any case, I'm going to merge this now and NOT close the issue as we'll need to discuss more about what we want to do wrt. the VCDM verification interface and this "verify multiple proofs" interface.

msporny commented 1 month ago

Normative, multiple reviews, changes requested and made, no objections, merging.