search

w3c / vc-data-integrity

W3C Data Integrity Specification
https://w3c.github.io/vc-data-integrity/
Other
41 stars 18 forks source link

Removal of the multibase datatype section #304

Closed iherman closed 2 weeks ago

iherman commented 3 weeks ago

When aligning with the controller specification, the section defining the multibase datatype was not removed. That datatype is now formally defined in the controller document (the formal vocabulary has already been changed).

Also, I have added a minor node making it clear that the context and vocabulary files, referred to in the section on contexts and vocabularies (§ 2.4) also includes terms defined in the controller document.

Preview | Diff

iherman commented 3 weeks ago

This seems ok to me. I'll note that this link:

https://github.com/w3c/vc-data-integrity/blob/main/vocab/security/vocabulary.yml#L277

Seems to be broken and should perhaps go to: https://www.w3.org/TR/controller-document/#assertion

Oops, that was the result of that historical anomaly of having "assertion" in the text and "assortionMethod" in the vocabulary. Which means that the remark on how the terms are defined in the controller document change in https://github.com/w3c/controller-document/pull/43 is actually incorrect, will have to change that...

msporny commented 2 weeks ago

Editorial, multiple reviews, changes requested and made, no objections (and unlikely to occur), merging so that merge conflicts don't appear as I do my final editorial pass on the document.