w3c / vc-data-model-2.0-test-suite

W3C Verifiable Credentials v2.0 test suite
https://w3c.github.io/vc-data-model-2.0-test-suite/
Other
11 stars 11 forks source link

Remove context order tests #18

Closed aljones15 closed 1 year ago

aljones15 commented 1 year ago

Skips two tests with normative statements not in the spec:

All libraries or processors MUST ensure that the order of the values in the @context property is what is expected for the specific application.

JSON-based processors MUST process the @context key, ensuring the expected values exist in the expected order for the credential type being processed.

The primary reason is that:

  1. the existing tests would require bespoke code in implementer's issues for the issuance of a VC
  2. I'm not sure the tests are actually that good, I think a better one would be to issue a VC with 3 contexts and then test to make sure those 3 context urls position in the array didn't change and that they're still there after issuing.

Current test data is below:

https://github.com/digitalbazaar/vc-data-model-2-test-suite/blob/638dbeaa6acdc2d1c6f2b338dc520db41680a4b5/tests/input/credential-context-order-ok.json#L2-L7

https://github.com/digitalbazaar/vc-data-model-2-test-suite/blob/638dbeaa6acdc2d1c6f2b338dc520db41680a4b5/tests/input/credential-context-order1-ok.json#L2-L6

https://github.com/digitalbazaar/vc-data-model-2-test-suite/blob/638dbeaa6acdc2d1c6f2b338dc520db41680a4b5/tests/input/credential-context-order2-fail.json#L2-L6

https://github.com/digitalbazaar/vc-data-model-2-test-suite/blob/638dbeaa6acdc2d1c6f2b338dc520db41680a4b5/tests/input/credential-context-order-fail.json#L2-L7

aljones15 commented 1 year ago

@msporny looking for consensus here:

A. skip the tests and keep the test data B. remove the tests and test data C. something else

msporny commented 1 year ago

@msporny looking for consensus here:

Let's do option B - remove tests and test data for now. Largely because the text has been removed from the current spec, IIRC.

B. remove the tests and test data

We can add it back in later if necessary.

aljones15 commented 1 year ago

test data and tests removed