w3c / vc-data-model-2.0-test-suite

W3C Verifiable Credentials v2.0 test suite
https://w3c.github.io/vc-data-model-2.0-test-suite/
Other
11 stars 11 forks source link

Remove before block issue & prove for stability. #25

Closed aljones15 closed 1 year ago

aljones15 commented 1 year ago

This is a safety precaution before this suite is publicly released. Currently in mocha if a before statement fails the tests just aren't run. In the case of this suite, that results in no implementations' tests running at all. In order to avoid this, the before statement has been removed so that if an implementation fails to issue a VC that implementation will fail the test the issuance fails on. This creates a more accurate test record while also removing the frustration of not being able to run the tests at all if a single implementer's issuer is down.

It does create 2 redundant calls on the issuer per implementation (up from one), but the stability is way more important IMHO if multiple implementers will be adding themselves to this suite.