search

w3c / vc-data-model-2.0-test-suite

W3C Verifiable Credentials v2.0 test suite
https://w3c.github.io/vc-data-model-2.0-test-suite/
Other
11 stars 11 forks source link

test approach for resource integrity #35

Open mprorock opened 1 year ago

mprorock commented 1 year ago

per pr w3c/vc-data-model#1140 need descriptions of test approach and possible other considerations regarding type and related for followon PRs

@OR13 for more color commentary if needed

iherman commented 1 year ago

The issue was discussed in a meeting on 2023-07-05

View the transcript #### 2.2. test approach for resource integrity (issue vc-data-model#1153) _See github issue [vc-data-model#1153](https://github.com/w3c/vc-data-model-2.0-test-suite/issues/35)._ **Manu Sporny:** This is definitely pre-CR. … It's about knowing how the group will test the feature. … We need thoughts from Mike P. on how to test the feature. Then we can close the issue. > *Michael Prorock:* +1 manu. **Manu Sporny:** It need to be there until there's an agreed upon plan. **Michael Prorock:** Assign me the issue.
OR13 commented 1 year ago

We should cross reference from the test suite repos... when we have them.

iherman commented 1 year ago

The issue was discussed in a meeting on 2023-08-02

View the transcript #### 2.4. test approach for resource integrity (issue vc-data-model#1153) _See github issue [vc-data-model#1153](https://github.com/w3c/vc-data-model-2.0-test-suite/issues/35)._ **Michael Prorock:** How do we test this? We could check if hash matches, build into VCDM tests -- fairly straight forward. **Kristina Yasuda:** Are you volunteering to do the PR? **Michael Prorock:** I can provide sample code for this, could go into PR, or whatever. > *Michael Prorock:* we did. **Orie Steele:** I might be misremembering, thought we added property for protecting context integrity, if securing specification wanted to demonstrate conformance, it would have to write tests around it. … Manu sent email about data integrity suites -- would expect to see some test case there for this, would also expect to see stuff for VC-COSE-JOSE test suite and would love to see that adopted. > *Michael Prorock:* +1 orie - and I am happy to add to vc-jose tests. **Orie Steele:** We dont' have adopted work items for test suites in group. **Kristina Yasuda:** Moving issue to VC-JOSE-COSE repo? **Orie Steele:** This particular core data model issue is fine to stay on core data model -- it will need to be tested concretely in test suites for securing core data model, those tests suites will use different approaches, I'd leave it where it is. … I'd file issues in test suites repos, if we had those.
OR13 commented 11 months ago

@mprorock how do we want to address this in spec.yaml?

We could bundle all contexts (url, content and hash) in each spec.yaml... that seems wasteful.

We could create a new kind of spec.yaml that can be referenced by the existing ones, so that the validation section, can "pass / succeed" by comparison to a "reference" as opposed to by comparison to a "value".