search

w3c / vc-data-model-2.0-test-suite

W3C Verifiable Credentials v2.0 test suite
https://w3c.github.io/vc-data-model-2.0-test-suite/
Other
9 stars 10 forks source link

Expand issuer property tests. #50

Closed aljones15 closed 6 months ago

BigBlueHat commented 7 months ago

@dlongley I'm on the fence for this one. I'm not sure we should be testing URL validity here...and I'm not even sure that most Verifiers would catch/care about that typo unless they tried to dereference the ID--which if required is not required by the data model spec. Consequently, I'm leaning toward not including this test at all, but would love your sage advice here.

dlongley commented 6 months ago

Can we put a number or boolean in the field (non-string) instead? If we already have such a test, let's strike this, if not, let's just use a non-string to handle the test case here.

aljones15 commented 6 months ago

Can we put a number or boolean in the field (non-string) instead? If we already have such a test, let's strike this, if not, let's just use a non-string to handle the test case here.

we can change to a number or boolean @BigBlueHat thoughts here? I actually think this is a fine solution.

BigBlueHat commented 6 months ago

we can change to a number or boolean @BigBlueHat thoughts here? I actually think this is a fine solution.

Fine by me.