w3c / vc-data-model-2.0-test-suite

W3C Verifiable Credentials v2.0 test suite
https://w3c.github.io/vc-data-model-2.0-test-suite/
Other
9 stars 10 forks source link

Adding annotations and did some clean up. #73

Closed BigBlueHat closed 1 month ago

BigBlueHat commented 1 month ago
BigBlueHat commented 1 month ago

@aljones15 @tminard I've been working my way through the spec adding these annotations to the code. They should be mostly up-to-date.

However, I'm wanting to pivot off of this baseline and refactor this test suite code a bit. It's currently painful to navigate it as the entire list of requirements is in on big bucket... So, once this is in, I plan to refactor, then return to annotating and sketching out what tests are missing.

BigBlueHat commented 1 month ago

@aljones15 if you're OK with this, I'd like to wait on doing the issuer.name and issuer.description test changes. I can make them part of #74 if you'd like--and likely move them into the currently skipped name and description test section. We can then discuss with others where else to run the name and description tests. Issuer seems like a good candidate (and they're already written), but we can certainly discuss testing them in credentialSubject as well (if/when present, of course).

But...I'd love to get this one merged before dealing with that larger move (and base it on #74's new groups).