search

w3c / vc-data-model

W3C Verifiable Credentials Working Group — VC Data Model and Representations specification
https://w3c.github.io/vc-data-model/
Other
281 stars 98 forks source link

clarify inputBytes, inputDocument, inputMediaType #1438

Closed TallTed closed 4 months ago

TallTed commented 4 months ago

fixes #1402

Preview | Diff

TallTed commented 4 months ago

Consistency is generally better than not.

That said, I don't like the change to encodingFormat because I don't think it's an accurate label nor particularly well defined by schema.org.

I also note (too late for that decision, but perhaps it might be reconsidered) https://www.w3.org/ns/iana/media-types/ which seems like it should be taken into account for W3 purposes.

iherman commented 4 months ago

Consistency is generally better than not.

That said, I don't like the change to encodingFormat because I don't think it's an accurate label nor particularly well defined by schema.org.

I have to agree with you on this. As I said, I can live with inconsistency; we just to agree that we all accept it.

I also note (too late for that decision, but perhaps it might be reconsidered) https://www.w3.org/ns/iana/media-types/ which seems like it should be taken into account for W3 purposes.

This is a very strange namespace (never saw this before). It seems to assign, for each specific media type, a class. If we used this, Example 28 would look like:

  "image": {
     "id": "https:....",
     "digestSRI" : "sha384-......",
     "type" : "https://www.w3.org/ns/iana/media-types/image/svg+xml#Resource"

this can work, but I am afraid it would be a bit unnatural to use...

@msporny @dlongley ?

TallTed commented 4 months ago

s/"https://www.w3.org/ns/iana/media-types/application/svg+xml#Resource"/"https://www.w3.org/ns/iana/media-types/image/svg+xml#Resource"/, I think?

(And, of course, the document at the latter link includes mention of application/svg+xml which is not listed in the main table on https://www.w3.org/ns/iana/media-types/. sighs)

iherman commented 4 months ago

s/"https://www.w3.org/ns/iana/media-types/application/svg+xml#Resource"/"https://www.w3.org/ns/iana/media-types/image/svg+xml#Resource"/, I think?

Yep, sorry. I will edit the comment just to make it o.k.

(And, of course, the document at the latter link includes mention of application/svg+xml which is not listed in the main table on https://www.w3.org/ns/iana/media-types/. sighs)

decentralgabe commented 4 months ago

@iherman this one ready too?

iherman commented 4 months ago

@decentralgabe yes. The issue of mediaType remaining is still pending, the other PR has been closed, so it should not affect this PR. Merge ahead...

decentralgabe commented 4 months ago

editorial approval, open >1 week, changes addressed. merging!