Remove note on verification methods; refactor proof validation section.

w3c / vc-data-model

W3C Verifiable Credentials Working Group — VC Data Model and Representations specification

https://w3c.github.io/vc-data-model/

Other

281 stars 98 forks source link

Remove note on verification methods; refactor proof validation section. #1452

Closed msporny closed 3 months ago

msporny commented 4 months ago

This PR is an attempt to address issue #1274 by removing the note on verification methods (since we now have a spec that defines those) and refactors the validation section to use more modern language.

Preview | Diff

iherman commented 3 months ago

The issue was discussed in a meeting on 2024-03-06

no resolutions were taken

View the transcript

#### 2.13. Tell a bit more about `verificationMethod` type schema (issue vc-data-model#1274) _See github issue [vc-data-model#1274](https://github.com/w3c/vc-data-model/issues/1274)._ _See github pull request [vc-data-model#1452](https://github.com/w3c/vc-data-model/pull/1452)._ **Brent Zundel:** 1274, PR1452 - large number of approvals, ready to be merged.

TallTed commented 3 months ago

[@brentzundel] ready to be merged

Questionable. I see 4 unresolved change requests/suggestions from me, the handling of which may lead to some additional change requests (e.g., do all instances of proof need to be changed to cryptographic proof? or all instances of cryptographic proof need to be changed to proof? or something else?)....

msporny commented 3 months ago

Editorial, multiple reviews, changes requested and made, no objections, merging.

msporny commented 3 months ago

@TallTed wrote:

Questionable. I see 4 unresolved change requests/suggestions from me, the handling of which may lead to some additional change requests

I made a pass, applied your changes, and applied some consistent language that you proposed. I think we're good now.