search

w3c / vc-data-model

W3C Verifiable Credentials v2.0 Specification
https://w3c.github.io/vc-data-model/
Other
290 stars 106 forks source link

Add section on enveloped verifiable presentations. #1453

Closed msporny closed 6 months ago

msporny commented 7 months ago

This PR is an attempt to address issue #1431 by adding a way of expressing an enveloped verifiable presentation.

/cc @christophera

Preview | Diff

iherman commented 7 months ago

@msporny this requires a change on the vocabulary as well, including a change in the vocabulary diagram. Do you prefer I do a modifiation on this branch directly (ie, adding the necessary changes) or should I do a separate PR on top of this branch? The former might be more efficient...

msporny commented 7 months ago

@iherman wrote:

Do you prefer I do a modifiation on this branch directly (ie, adding the necessary changes)

Yes, please. Thank you!

iherman commented 7 months ago

@iherman wrote:

Do you prefer I do a modifiation on this branch directly (ie, adding the necessary changes)

Yes, please. Thank you!

Done in https://github.com/w3c/vc-data-model/pull/1453/commits/43ed6e7d22344884221974fe1b9194a61f5378a4

OR13 commented 7 months ago

Non blocking comment here:

The @context configuration controls how edges form between credentials and the presentation.

In the case that JSON-LD extensibility mechanisms of the presentation object are used, implementers may want to do custom RDF processing to maintain associations between a single outer presentation and inner credentials.

In those cases, the RDF context defined in the spec does not actually control how the information graph grows.

iherman commented 6 months ago

The issue was discussed in a meeting on 2024-03-06

View the transcript #### 2.14. EnvelopedVerifiablePresentation missing in data model (issue vc-data-model#1431) _See github issue [vc-data-model#1431](https://github.com/w3c/vc-data-model/issues/1431)._ _See github pull request [vc-data-model#1453](https://github.com/w3c/vc-data-model/pull/1453)._ **Brent Zundel:** 1431, PR1453 which has approvals and on track to be merged. … we're headed toward wrapping this up. … so expect to be bothered by us to get the work done...probably weekly.
msporny commented 6 months ago

@OR13 wrote:

In the case that JSON-LD extensibility mechanisms of the presentation object are used, implementers may want to do custom RDF processing to maintain associations between a single outer presentation and inner credentials.

I added some wording to highlight your concern in 2cf9040fa2a657c6ecdd74e37c9ecbdf1e664169.

In those cases, the RDF context defined in the spec does not actually control how the information graph grows.

Debatable; an implementation might want it the @context to apply, or it might decide to not propagate it into the referenced object.

Given that this feature is largely meant to just encapsulate a VP encoded in just about any media type, and most of those media types won't really care about the RDF-ness of the outer-most object, it's probably fine to just stay silent on this point until the next round of the VC spec. We'd want to gather implementation experience of what people do with this before we provide more specific guidance (if that becomes necessary).

msporny commented 6 months ago

Normative, multiple reviews, changes requested and made, no objections, merging.