search

w3c / vc-data-model

W3C Verifiable Credentials Working Group — VC Data Model and Representations specification
https://w3c.github.io/vc-data-model/
Other
281 stars 97 forks source link

Update ecosystem.svg (fix Holder's verb tense) #1470

Closed TallTed closed 2 months ago

davidlehn commented 2 months ago

Direct SVG updates will be lost when the source .drawio file is updated. See https://github.com/w3c/vc-data-model/blob/main/diagrams/README.md. In this case perhaps you can get away with updating the string direct in the .drawio file too.

iherman commented 2 months ago

Direct SVG updates will be lost when the source .drawio file is updated. See https://github.com/w3c/vc-data-model/blob/main/diagrams/README.md. In this case perhaps you can get away with updating the string direct in the .drawio file too.

In general, that is true. In this case, the best is to change both the drawio and the svg files. (In theory, a script is run against the generated SVG to remove unnecessary size attributes in the SVG element and format the file; see also the readme. For a single letter change it should be all right to hack both files.)

TallTed commented 2 months ago

Thanks, @davidlehn. I've patched the .drawio to match the patched SVG.

msporny commented 2 months ago

Editorial, multiple reviews, changes requested and made, no objections, merging.