search

w3c / vc-data-model

W3C Verifiable Credentials v2.0 Specification
https://w3c.github.io/vc-data-model/
Other
299 stars 106 forks source link

Unify input value to verification algorithm. #1523

Closed msporny closed 4 months ago

msporny commented 4 months ago

This PR is an attempt to address issue #1518 by unifying the input value to cryptosuite verification algorithms.

/cc @jyasskin @PatStLouis @filip @silverpill @flechtner

Preview | Diff

TallTed commented 4 months ago

I don't know if it's possible to edit a commit comment after the fact, but https://github.com/w3c/vc-data-model/pull/1523/commits/f0e2ef94ede235024862de83d67fd00669ae49d7 should say Remove errant "and", not Remove errant "to". :-)

msporny commented 4 months ago

I don't know if it's possible to edit a commit comment after the fact, but f0e2ef9 should say Remove errant "and", not Remove errant "to". :-)

It is, you have to rewrite git history to do it via git commit --amend (amend the last commit comment made), which I just did for this PR.

msporny commented 4 months ago

Editorial, multiple reviews, changes requested and made, no objections, merging.