w3c / vc-data-model

W3C Verifiable Credentials v2.0 Specification
https://w3c.github.io/vc-data-model/
Other
299 stars 106 forks source link

Added the new vocabulary file for undefined terms #1536

Closed iherman closed 3 months ago

iherman commented 4 months ago

This is to settle issue #1534. Some remarks, though:

Here is the .htaccess file itself:

RewriteEngine On
RewriteBase /ns/credentials/
AddType application/ld+json .jsonld
AddType text/turtle .ttl

# The v2 of the core VCDM JSON-LD context:
RewriteRule ^v2$ https://w3c.github.io/vc-data-model/contexts/credentials/v2 [E=json,P]

# The vocabulary referred to via a @vocab statement at the end of the core VCDM JSON-LD context
# This was removed, see https://github.com/w3c/vc-data-model/pull/1536
# RewriteRule ^issuer-dependent$ https://w3c.github.io/vc-data-model/vocab/credentials/v2/issuer-dependent.html [P]

# The v2 of the example JSON-LD context, used for the examples in the VCDM specification
RewriteRule ^examples/v2$ https://w3c.github.io/vc-data-model/contexts/credentials/examples/v2 [E=json,P]
# The v2 example context file is just a @vocab statement to ns/credentials/examples
RewriteRule ^examples$ https://w3c.github.io/vc-data-model/vocab/credentials/v2/examples.html [P]
RewriteRule ^examples#$ https://w3c.github.io/vc-data-model/vocab/credentials/v2/examples.html [P]

# The v2 of the undefined term JSON-LD context, used for the undefined terms in the VCDM specification
RewriteRule ^undefined-term/v2$ https://w3c.github.io/vc-data-model/contexts/credentials/undefined-term/v2 [E=json,P]
# The v2 example context file is just a @vocab statement to ns/credentials/examples
RewriteRule ^undefined-term$ https://w3c.github.io/vc-data-model/vocab/credentials/v2/undefined-term.html [P]
RewriteRule ^undefined-term#$ https://w3c.github.io/vc-data-model/vocab/credentials/v2/undefined-term.html [P]

#### Status list additions
RewriteRule ^status$ https://www.w3.org/ns/credentials/status/ [P]

Header set Content-Type application/ld+json env=json
msporny commented 3 months ago

We would be better off with @vocab in the main context so there are no undefined terms.

That ship has sailed. PR #1520, removing @vocab from the base context, was merged after considerable debate and with WG consensus.

iherman commented 3 months ago

The issue was discussed in a meeting on 2024-07-31

View the transcript #### 1.3. Publish undefined-terms context URI (issue vc-data-model#1534) _See github issue [vc-data-model#1534](https://github.com/w3c/vc-data-model/issues/1534)._ _See github pull request [vc-data-model#1536](https://github.com/w3c/vc-data-model/pull/1536)._ **Manu Sporny:** for next item Ivan has raised a PR, once those three are done, no more issues on VCDM. … only thing waiting on then is for test suites to demonstrate multiple independent implementations for every feature in specification.
iherman commented 3 months ago

@msporny can this PR be merged (and the .htaccess file updated)?

iherman commented 3 months ago

The issue was discussed in a meeting on 2024-08-07

View the transcript #### 1.1. Added the new vocabulary file for undefined terms (pr vc-data-model#1536) _See github pull request [vc-data-model#1536](https://github.com/w3c/vc-data-model/pull/1536)._ **Brent Zundel:** We have a PR we should look at. … There are a number of requests for changes here, Ivan can you give us a summary of what the PR does? … I encourage folks who would like changes to also jump in. **Ivan Herman:** Just to say what you said here a little differently. There were a number of comments, so they have all been incorporated, so as far as I know, no more open comments. … What it does is -- following up on the PR(s) which changed the place for the `@vocab` term and now there is a separate undefined term that has to be done properly and this PR handles that. … There is one part of the PR that isn't in there which is for htaccess file changes I have to do externally. … This will handle redirections, etc. it's not on github, won't be subject to PR, but I put a verbatim copy of the .htaccess file. … There were some small comments incorporated on that as well, as far as I am concerned this can be merged and then I will change the .htaccess file after that. **Brent Zundel:** Thanks for that summary, Ivan. … To add a little bit more context, I believe three weeks ago this group came to consensus on and merged two PRs to make changes to add the undefined terms context and remove the `@vocab` from the core context. … This PR just does administrative work to finish up those things that were done nearly a month ago. **Ivan Herman:** That is correct. **Brent Zundel:** Ted and Mike Jones, your reviews are still showing requests for changes, Ted your changes have been merged, Mike if you'd like to jump on the queue you can do so. **Michael Jones:** Alright, I still think it's a mistake but I think the ship has sailed and I'll approve it. **Brent Zundel:** Thank you Mike, I appreciate that. … Ok, if there are no more comments on this PR, then we can look briefly at our set of issues. > *Brent Zundel:* [https://github.com/w3c/vc-data-model/issues?q=is%3Aissue+is%3Aopen+-label%3Afuture+sort%3Aupdated-asc](https://github.com/w3c/vc-data-model/issues?q=is%3Aissue+is%3Aopen+-label%3Afuture+sort%3Aupdated-asc). **Brent Zundel:** There are two remaining issues on the VCDM. … I think the first issue will be addressed by the PR we just looked at.
iherman commented 3 months ago

Merging per https://www.w3.org/2017/vc/WG/Meetings/Minutes/2024-08-07-vcwg#section1-1. The .htaccess file has also been updated on the W3C server.