w3c / vc-di-bbs-test-suite

Interoperability Test Suite for Data Integrity BBS Signatures
https://w3c.github.io/vc-di-bbs-test-suite
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Add initial config #13

Closed aljones15 closed 4 months ago

aljones15 commented 4 months ago

Features:

  1. Adds initial /config dir
  2. Adds /confg/respect.json
  3. Adds /config/runner.json
  4. Adds /config/keys.json
  5. Adds /config/vectors.json
  6. All suites now uses configurable tags property
  7. Suites use vectors
  8. Interop tests are skipped by default
  9. An initial keyPair has been added
  10. Adds vc 1.1 and vc 2.0 test fixtures

This does not add a local verifier yet This does not add a vc-generator yet, but moves towards having a VC generator. This does not abstract the suites into functions which can take VCs or multiple types

BigBlueHat commented 4 months ago

WRT to your comments above about the sails vectors, the vc 2.0 one is used in the verify suite. It goes by the name subjectHasArrays in that suite. The verifier test data is similarly overly complicated and as confusing as the ecdsa sd verifier test data is sadly.

Interesting info, but not sure it answers why they're here in this BBS test suite (at least not now in this PR). Are you planning to use them in future? If so, it'd be best to put them on a topical branch with that code.

aljones15 commented 4 months ago

WRT to your comments above about the sails vectors, the vc 2.0 one is used in the verify suite. It goes by the name subjectHasArrays in that suite. The verifier test data is similarly overly complicated and as confusing as the ecdsa sd verifier test data is sadly.

Interesting info, but not sure it answers why they're here in this BBS test suite (at least not now in this PR). Are you planning to use them in future? If so, it'd be best to put them on a topical branch with that code.

the vectors are used in the bbs verify suite currently.