(7) Add invalid date test

w3c / vc-di-bbs-test-suite

Interoperability Test Suite for Data Integrity BBS Signatures

https://w3c.github.io/vc-di-bbs-test-suite

BSD 3-Clause "New" or "Revised" License

1 stars 0 forks source link

(7) Add invalid date test #33

Closed aljones15 closed 2 months ago

aljones15 commented 2 months ago

Adds an invalid created test for the base and by extension derived proof.

TODO

[x] Use a generator to ensure created still shows up in the proof until the implementation used for test data creation can support proof.created.

aljones15 commented 2 months ago

Looks like this PR also includes #34, it makes it difficult to see what belongs to this PR

I retargeted it to point at PR 34. Sorry about that.

aljones15 commented 2 months ago

@TallTed also need re-review here when ready.

TallTed commented 2 months ago

this PR has been dangling for 2 weeks

Hardly. It's been actively worked on for 2 weeks. It might be considered to have "dangled" for 1 day (since @PatStLouis's approving review), but I think that the "dangling" time is closer to 2 hours, which was more like 1 hour when the above line was written.

aljones15 commented 2 months ago

this PR has been dangling for 2 weeks

Hardly. It's been actively worked on for 2 weeks. It might be considered to have "dangled" for 1 day (since @PatStLouis's approving review), but I think that the "dangling" time is closer to 2 hours, which was more like 1 hour when the above line was written.

my apologies @TallTed and no offense meant.

TallTed commented 2 months ago

Accepted.