search

w3c / vc-di-bbs-test-suite

Interoperability Test Suite for Data Integrity BBS Signatures
https://w3c.github.io/vc-di-bbs-test-suite
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

enumerated elements should match the counts of those elements #64

Open TallTed opened 2 hours ago

TallTed commented 2 hours ago

_Originally posted by @TallTed in https://github.com/w3c/vc-di-bbs-test-suite/pull/63#discussion_r1809211211_

The first paragraph of 3.3.7 parseDerivedProofValue —

A single derived proof value object is produced as output, which contains a set of six or seven elements, having the names "bbsProof", "labelMap", "mandatoryIndexes", "selectiveIndexes", "presentationHeader", "featureOption", and, depending on the value of the featureOption parameter, "pseudonym" and/or "lengthBBSMessages".

— is internally inconsistent (the set may have six, seven, or eight elements) and it disagrees with the last paragraph of that algorithm (again, should say "six, seven, or eight elements" including "featureOption", "pseudonym" and/or "lengthBBSMessages") —

Return derived proof value as an object with properties set to the five, six, or seven elements, using the names "bbsProof", "labelMap", "mandatoryIndexes", "selectiveIndexes", "presentationHeader", and optional "pseudonym" and/or "lengthBBSMessages", respectively. In addition, add featureOption and its value to the object.

These should be brought into agreement. Whatever the result is, it should then be applied to this part of the test suite.

TallTed commented 2 hours ago

This should probably be moved to the https://github.com/w3c/vc-di-bbs/ repo. (I can't, or I would.)