search

w3c / vc-di-bbs

A linked data proof suite specification for BBS+ signatures
https://w3c.github.io/vc-di-bbs/
Other
48 stars 16 forks source link

dueling edits #178

Open TallTed opened 3 months ago

TallTed commented 3 months ago

https://github.com/w3c/vc-di-bbs/blob/3f3585f8ca3162e019890531b5d73058a3f8727e/index.html#L1475

The second if is unnecessary. Even better, replace the later if the with its.

To be explicit, change — If |proofConfig|.|created| is set and if the value is not a — to — If |proofConfig|.|created| is set and its value is not a

There seem to be dueling PRs for this. It was changed earlier today, but now it doesn't appear appears to have been (or was un-changed) un-changed.

If there are different opinions about this phrasing, I would like to get them hammered out, and a final PR made.

TallTed commented 3 months ago

Also note the parallel line, which must be synced with the above —

https://github.com/w3c/vc-di-bbs-test-suite/blob/46e767307e12482bea5ada24d2f0d16e73bd011f/tests/suites/verify.js#L139C1-L140C1

aljones15 commented 3 months ago

interesting, some of @Wind4Greg changes were also regressed https://github.com/w3c/vc-di-bbs/pull/179