search

w3c / vc-di-ecdsa-test-suite

Interoperability Test Suite for Data Integrity Ecdsa Signatures.
https://w3c.github.io/vc-di-ecdsa-test-suite/
BSD 3-Clause "New" or "Revised" License
5 stars 6 forks source link

ECDSA-SD-2023 proofValue encoding is base64url no padding #41

Closed filip26 closed 5 months ago

filip26 commented 6 months ago

A test on proofValue encoding requires proofValue be encoded with base58btc for ecdsa-sd-2013, but the spec asks for base64url no padding.

There is an inconsistency in the spec, (see https://github.com/w3c/vc-di-ecdsa/issues/55) asking base58btc generally but then requiring base64url no padding only for ecdsa-sd-2013

tminard commented 6 months ago

@filip26 I think you meant ecdsa-sd-2023?

I just merged a fix to data-integrity-test-suite-assertion that resolves this.

filip26 commented 6 months ago

@tminard yes I did, ECDSA-SD-2023

tminard commented 6 months ago

Awesome - thanks @filip26! Makes sense. Are you able to re-run the test and see if this is still an issue? I believe we can close this now.

I verified with folks that the spec is currently correct: specific cryptosuites have normative statements around the specific multibase encoding expected for proof.proofValue. The test suites now account for this.

aljones15 commented 5 months ago

@tminard @filip26 closing as I believe this has been addressed