search

w3c / vc-di-ecdsa

Data Integrity specification for ECDSA using NIST-compliant curves
https://w3c.github.io/vc-di-ecdsa/
Other
9 stars 9 forks source link

Update crypto-suite names #23

Closed Wind4Greg closed 10 months ago

Wind4Greg commented 11 months ago

This PR updates the cryptography suite names to conform to VC-Data Integrity specification.

This PR does not change the content of the examples or test vectors. Those will be updated after this PR is accepted and merged.

Preview | Diff

msporny commented 10 months ago

@OR13 wrote:

This a subtle change, but I believe it reflects well working group consensus on this topic at the previous face to face, and it highlights an important extension point for data integrity proofs.

Alright, good, then looks like we have consensus on this topic.

@Wind4Greg @dmitrizagidulin @iherman -- we need to register a new cryptosuite type in the security vocabulary for DataIntegrityProofs such that we can compress these longer strings into single byte values during semantic compression processes like what's used by CBOR-LD. I've opened https://github.com/w3c/vc-data-integrity/issues/161 to track this concern, which doesn't need to hold up this PR.

msporny commented 10 months ago

Normative, multiple reviews, no changes requested, no objections, merging.

msporny commented 10 months ago

Now that this is merged, @Wind4Greg, let's make a pass over all the cryptosuites and apply the naming uniformly over all of them, merge the sec:cryptosuiteString feature, regenerate all of the test vectors and finally be done with all of this. :)

Wind4Greg commented 10 months ago

Agree @msporny. Will review all for consistency. Have new test vectors ready to integrate into the documents.