search

w3c / vc-di-ecdsa

Data Integrity specification for ECDSA using NIST-compliant curves
https://w3c.github.io/vc-di-ecdsa/
Other
9 stars 9 forks source link

Enhance description of skolemizeExpandedJsonLd, variable naming, id string #40

Closed Wind4Greg closed 9 months ago

Wind4Greg commented 9 months ago

The function skolemizeExpandedJsonLd is a key primitive within the set of selective disclosure primitives. This PR contains:

  1. An enhanced description of what this function does (important to promote understanding)
  2. Small clarifying enhancements to variable naming
  3. Fixes variable naming/use inconsistencies
  4. Small fixes to blank node id generation to match that produced by libraries used to produced ECDSA-Test vectors (a missing underscore "_" in the format string)

@dlongley please review. I was able to recreate functionality from specification description and suggest these changes to help others.

Preview | Diff

msporny commented 9 months ago

Minor normative change, multiple reviews, changes requested and made, no objections, merging.