search

w3c / vc-di-ecdsa

Data Integrity specification for ECDSA using NIST-compliant curves
https://w3c.github.io/vc-di-ecdsa/
Other
9 stars 9 forks source link

Make all Multicodec / Multibase references non-normative. #42

Closed msporny closed 8 months ago

msporny commented 9 months ago

This PR attempts to address issue #39 by making all Multicodec / Multibase references non-normative and cites the normative sections of PR https://github.com/w3c/vc-data-integrity/pull/196 as requested by the issue submitter.

Preview | Diff

iherman commented 9 months ago

My original review comment is moot, in view of https://github.com/w3c/vc-data-integrity/pull/196#issuecomment-1738316947. Changing the review.

msporny commented 9 months ago

@selfissued there are now no references to the IETF I-Ds on Multiformats, we instead either normatively define the values needed in the spec, or refer back to VC Data Integrity, which defines the values needed. Requesting re-review.

msporny commented 8 months ago

This spec is still referencing ?MULTIBASE rather than normative definitions of the features used.

Sorry, there was code stuck on my local copy that removed all those references, requesting another re-review from you.

msporny commented 8 months ago

@selfissued re-ping to re-review... ideally, you approve before we merge this. It's all green on reviews so far.

iherman commented 8 months ago

The issue was discussed in a meeting on 2023-10-11

View the transcript #### 1.3. Make all Multicodec / Multibase references non-normative. (pr vc-di-ecdsa#42) _See github pull request [vc-di-ecdsa#42](https://github.com/w3c/vc-di-ecdsa/pull/42)._ **Manu Sporny:** I see he's approved the last remaining well as well. … That is great, that unblocks us across the board for all DI and cryptosuite specs. … That's that item, we can shift back to VCDM. **Brent Zundel:** There are a lot of VCDM PRs.
msporny commented 8 months ago

Normative, multiple reviews, changes requested and made, no objections, merging.