search

w3c / vc-di-ecdsa

Data Integrity specification for ECDSA using NIST-compliant curves
https://w3c.github.io/vc-di-ecdsa/
Other
9 stars 9 forks source link

JCS Context Injection #61

Closed Wind4Greg closed 2 weeks ago

Wind4Greg commented 1 month ago

This PR addresses issue https://github.com/w3c/vc-data-integrity/issues/225 to properly handle @context injection issues that could arise with JCS. Note that this also applies to @context issues that could arise with proof sets/chains with JCS. This PR contains normative changes to the Create Proof (ecdsa-jcs-2019) and Verify Proof (ecdsa-jcs-2019) algorithms.

This PR does NOT include informative text such as:

  1. Explanation of why these steps are necessary and sufficient. Such informative text is present in the discussions of issue https://github.com/w3c/vc-data-integrity/issues/225 and could be extracted and included somewhere in the document. Thoughts?
  2. Updates to the current ecdsa-jcs-2019 test vectors in the specification. Will be updated after this PR is reviewed.

Preview | Diff

msporny commented 2 weeks ago

Normative, multiple reviews, no changes requested, no objections, merging.