search

w3c / vc-di-eddsa

EdDSA Data Integrity Cryptosuites Specification
https://w3c.github.io/vc-di-eddsa/
Other
12 stars 10 forks source link

Fix B.3 Representation: Ed25519Signature2020 test vectors #76

Closed filip26 closed 6 months ago

filip26 commented 7 months ago

Adds missing @context https://w3id.org/security/suites/ed25519-2020/v1 to Ed25519Signature2020 test vectors. Proof canonical form, hash, and signature are re-computed.

It's related to, but does not close, issue #75

Preview | Diff

w3cbot commented 7 months ago

iherman marked as non substantive for IPR from ash-nazg.

msporny commented 6 months ago

@filip26, thanks for the PR -- do you know if these updates align w/ other implementations (I imagine they do since you're passing the test suite?)

@Wind4Greg, what's going on with these test vectors? Are these updates correct?

filip26 commented 6 months ago

@msporny Without a proper Ed25519Signature2020 context, the proof is expanded with using of example context, e.g. https://www.w3.org/ns/credentials/examples#Ed25519Signature202 instead of https://w3id.org/security#Ed25519Signature2020. This PR fixes that.

I expect no issues for other implementations, on the contrary, without the right context, the result using example context is not verifiable, i.e. a proof type is unknown to a verifier.

Wind4Greg commented 6 months ago

Thanks @filip26 and @msporny! Let me update my test vector code and see if I can confirm. Cheers Greg