search

w3c / vc-extensions

Verifiable Credential Extensions
https://w3c.github.io/vc-extensions/
Other
12 stars 14 forks source link

Add registration example to respec #10

Closed OR13 closed 1 year ago

OR13 commented 1 year ago

Add example to respec

Preview | Diff

David-Chadwick commented 1 year ago

I should like to request an addition to this PR, namely to add definitions for each of the properties in the example. The current text is either not there, too brief or ambiguous.

msporny commented 1 year ago

@OR13 do you want to do what @David-Chadwick is asking in this PR or a separate PR? Let me know when to merge.

OR13 commented 1 year ago

@msporny I will add the definitions to this PR, hold on merging.

msporny commented 1 year ago

@msporny I will add the definitions to this PR, hold on merging.

Ping @OR13 -- status on this PR? I'd like to merge it sooner than later.

OR13 commented 1 year ago

Ready to be merged @msporny thank you for the ping, I had forgotten.

msporny commented 1 year ago

Ready to be merged

PR looks great, ty @OR13!

Normative, multiple reviews, changes requested and made, no objections, merging.