w3c / vc-imp-guide

Verifiable Credentials Implementation Guidelines
https://w3c.github.io/vc-imp-guide
Other
19 stars 15 forks source link

variable vocab is being discussed as if invariable #22

Closed TallTed closed 5 years ago

TallTed commented 5 years ago

We don't want them to have to worry about terms being redefined in unexpected ways. That way their software can inspect only the <code>@context</code> values and then be hard coded to understand the meaning of the terms.

This basically says, "we want them to act as if the definition of those terms is immutable" even as we're saying "the definition of these terms might change."

That's not OK!

Anything that's being hard-coded SHOULD (and I really want this to be MUST) be based on something that's immutable. The meaning of schema:name might change between VC creation and verification, and that's a problem.

If the @context were hashlinked, that might be a solution.

Or the example could be based on a static, immutable vocab that we include with this guide.

See comment threads in #18

brentzundel commented 5 years ago

I share this concern

deiu commented 5 years ago

I will add some text mentioning best practices re. schema.org.

TallTed commented 5 years ago

I will add some text mentioning best practices re. schema.org.

The concern is not focused on schema.org, per se, but on any third party vocabulary, over which neither issuer, holder, nor verifier may have any control, and which may change between VC creation and verification.

dmitrizagidulin commented 5 years ago

(Adding this link in case it's helpful, pr 272 to the DID spec discusses vocab versioning.)

deiu commented 5 years ago

Thanks for the pointer, @dmitrizagidulin!

deiu commented 5 years ago

I've opened PR #54 for this issue.