Closed OR13 closed 1 year ago
@TallTed thank you for the suggestions, your text was much better.
I have merged all except for this one: https://github.com/w3c/vc-jwt/pull/111#discussion_r1244391642
I am dreading the conflict resolution for this, so I want to get all your changes merged into the branch before I attempt to resolve that, since I might have an easier time just lifting the section into a new PR.
@TallTed I have accepted all your changes, before I attempt to resolve merge conflicts.
@dlongley @TallTed do you have any more suggestions?
Regarding your comment on kid
, I can't do much more on that front given the RFCs don't do much more, but I am happy to review suggestions if you have any.
This is good for this go-round. I don't have a suggestion on kid
, so I suggest creating a fresh issue about that need, fixing this PR's conflicts, and merging this PR. Someone else may then come up with a suggestion on kid
.
@TallTed
There are a lot of open issues related to kid
Most of them have some relationship to your question, here is an example:
https://github.com/w3c/vc-jwt/issues/31
Are you asking for an issue marker?
Or is it ok to just use the issue above?
I've created https://github.com/w3c/vc-jwt/issues/117 for this.
@TallTed
There are a lot of open issues related to
kid
Most of them have some relationship to your question, here is an example:
w3c/vc-jose-cose#31
Are you asking for an issue marker?
Or is it ok to just use the issue above?
i think referencing issue w3c/vc-jose-cose#31 works for me
@TallTed I think I have your suggestions, let me know if I missed anything.
@dlongley I applied most of your suggestions, but this one is outstanding: https://github.com/w3c/vc-jwt/pull/111#discussion_r1248283590
Is the issue marker I proposed acceptable?
I'm trying to resolve all suggestions before addressing the merge conflicts, because I am bad at git.
This list of related issues needs to go in to an issue marker, before this is merged:
Ok, I think I am ready to tackle the merge conflict, wish me luck.
@mprorock I believe all feedback has been addressed, and issue markers have been filed, I suggest we merge this.
Preview | Diff