w3c / vc-jose-cose

Verifiable Credentials Working Group — VC JSON Web Tokens specification
https://w3c.github.io/vc-jose-cose/
Other
31 stars 13 forks source link

Withdraw `application/vc+ld+json+jwt` and `application/vp+ld+json+jwt` #141

Closed OR13 closed 1 year ago

OR13 commented 1 year ago

Reasoning.

  1. "alg: none" is legal per JWT, in +sd-jwt it's not legal "MUST NOT be none or an identifier for a symmetric algorithm (MAC)."
  2. +sd-jwt supports all the signature algorithms, making support for +jwt redundant.
  3. One less media type to get wrong.
  4. (downside) no MAC based signatures for "W3C Verifiable Credentials".

This would simplify a lot of the spec text, and leave us with 1 envelope format for JSON (+sd-jwt), and one for CBOR (+cose).

This would leave only:

brentzundel commented 1 year ago

This makes good sense to me and also matches our implementation afaict.

mprorock commented 1 year ago

makes a lot of sense, and likewise matches our implementation

dwaite commented 1 year ago

Is there a degenerative form of SD-JWT for issuers who do not want selective disclosure?

OR13 commented 1 year ago

@dwaite afaik, yes, you get a JWT with an extra ~ (not a JWT per the media type serialization rules) in the case where you choose not to make any claims selective disclosable.

msporny commented 1 year ago

you get a JWT with an extra ~

That's not a JWT... it will fail processing w/ a regular JWT library, no?

OR13 commented 1 year ago

@msporny it will fail the serialization requirements from https://www.iana.org/assignments/media-types/application/jwt

Sakurann commented 1 year ago

+1 to this approach.

when SD not needed, remove ~ and then use a JWT lib. <- fully legal in sd-jwt spec

alenhorvat commented 1 year ago

Either ~ is removed (so 0 ~) or 2 ~~ are needed in the sd-jwt (1st separates the disclosures, 2nd the "key binding vc").

In the current proposal in the limit of 0 disclosures we end up with 2 different encodings for the same content.

selfissued commented 1 year ago

This is addressed by PR #149

OR13 commented 1 year ago

we did this.