search

w3c / vc-jose-cose

Verifiable Credentials Working Group — VC JSON Web Tokens specification
https://w3c.github.io/vc-jose-cose/
Other
30 stars 9 forks source link

Opinions #150

Closed bob420-svg closed 1 year ago

bob420-svg commented 1 year ago

What about this?

TallTed commented 1 year ago

What about this?

Are you now a member of the W3C Verifiable Credentials Working Group, and therefore able to make substantive contributions (which this may or may not be; I have not evaluated it)?

What issue are you trying to address with this pull request?

bob420-svg commented 1 year ago

I give up idk how to do this.

On Fri, Sep 8, 2023, 11:44 AM Ted Thibodeau Jr @.***> wrote:

What about this?

Are you now a member of the W3C Verifiable Credentials Working Group, and therefore able to make substantive contributions (which this may or may not be; I have not evaluated it)?

What issue are you trying to address with this pull request?

— Reply to this email directly, view it on GitHub https://github.com/w3c/vc-jose-cose/pull/150#issuecomment-1711955695, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7U7HVICN5JNGUDXKU63IT3XZNDOVANCNFSM6AAAAAA4QT6X6I . You are receiving this because you authored the thread.Message ID: @.***>

OR13 commented 1 year ago

I think this is a possible security threat, it proposes github actions that access the repo token secret, I am closing out of an abundance of caution but I will review further.

OR13 commented 1 year ago

I reviewed these changes, they don't seem malicious.

I don't think this repo needs them though.

bob420-svg commented 1 year ago

Bro I don't know how to do this. I've tried and all that happens is me fucking shit up. Someone else can take over.

On Fri, Sep 8, 2023, 3:16 PM Orie Steele @.***> wrote:

I reviewed these changes, they don't seem malicious.

I don't think this repo needs them though.

— Reply to this email directly, view it on GitHub https://github.com/w3c/vc-jose-cose/pull/150#issuecomment-1712176031, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7U7HVLMCUZPPJVTWJOYRE3XZN4JLANCNFSM6AAAAAA4QT6X6I . You are receiving this because you authored the thread.Message ID: @.***>

bob420-svg commented 1 year ago

I can't figure github out.

On Fri, Sep 8, 2023, 3:37 PM Casper Ghost @.***> wrote:

Bro I don't know how to do this. I've tried and all that happens is me fucking shit up. Someone else can take over.

On Fri, Sep 8, 2023, 3:16 PM Orie Steele @.***> wrote:

I reviewed these changes, they don't seem malicious.

I don't think this repo needs them though.

— Reply to this email directly, view it on GitHub https://github.com/w3c/vc-jose-cose/pull/150#issuecomment-1712176031, or unsubscribe https://github.com/notifications/unsubscribe-auth/A7U7HVLMCUZPPJVTWJOYRE3XZN4JLANCNFSM6AAAAAA4QT6X6I . You are receiving this because you authored the thread.Message ID: @.***>