search

w3c / vc-jose-cose

Verifiable Credentials Working Group — VC JSON Web Tokens specification
https://w3c.github.io/vc-jose-cose/
Other
30 stars 9 forks source link

Use Correct Names for Things #156

Closed selfissued closed 11 months ago

selfissued commented 1 year ago

This replaces uses of non-standard names like "claimset" and inaccurate IANA registry names with the actual names from the specifications. It also clarifies how many of the things named are used to align with the referenced specifications.

Preview | Diff

iherman commented 12 months ago

The issue was discussed in a meeting on 2023-09-14

View the transcript #### 6.6. Use Correct Names for Things (pr vc-jose-cose#156) _See github pull request [vc-jose-cose#156](https://github.com/w3c/vc-jose-cose/pull/156)._ **Michael Jones:** last PR. editorial. fixes things that should have been fixed. **Brent Zundel:** action is to review. > *Manu Sporny:* PR looks good, in general, good to call things by the right name. **Brent Zundel:** nothing controversial, expect to go in in few days. > *Joe Andrieu:* Also, Kristina, I'm not sure I answered your earlier question correctly. A purely relative component would only make sense if the base is set to the DID. "#key1" would only make sense if you're in a context where the base is well-defined and hence maps to a fully qualified URL. So, if the fragment is in a DID Document, we're all good. > *Manu Sporny:* yes, what Joe said above ^ relative URLs only work when you're in a DID Document. > *Manu Sporny:* but it's not clear if that works for everwhere we'd find a kid. > *Kristina Yasuda:* thank you, Joe!
OR13 commented 12 months ago

@selfissued conflicts exist, you may want to address them before applying suggestions