search

w3c / vc-jose-cose

Verifiable Credentials Working Group — VC JSON Web Tokens specification
https://w3c.github.io/vc-jose-cose/
Other
31 stars 13 forks source link

Address `kid` #163

Closed OR13 closed 1 year ago

OR13 commented 1 year ago

Attempt to close remaining kid issues: #30 and #117

Preview | Diff

vdods commented 1 year ago

Looks great!

Though I think there might be a typo in the links to "DID URL" -- they point to "relative DID URL":

When the <a data-cite="VC-DATA-MODEL#dfn-issuers">issuer</a> is identified as a <a data-cite="DID-CORE#did-subject">DID Subject</a>, 
        the <a href="#kid">kid</a> MUST be an absolute <a data-cite="DID-CORE#relative-did-urls">DID URL</a>.

I believe there are a few places in the changes that have this typo.

If this is intentional, then please ignore this comment.

OR13 commented 1 year ago

It is intentional, I found that section most helpful in explaining the difference.

TallTed commented 1 year ago

@OR13 -- Please let me know if you need a PR from me for the above minor tweaks to this. I would have preferred to submit them as change requests before this PR was merged, but time travel remains tragically unavailable.

OR13 commented 1 year ago

@TallTed please raise a PR to make these suggestions.

TallTed commented 1 year ago

Done. See #171.