search

w3c / vc-jose-cose

Verifiable Credentials Working Group — VC JSON Web Tokens specification
https://w3c.github.io/vc-jose-cose/
Other
30 stars 9 forks source link

credentialSchema property not fully correct in PR#159 examples #164

Closed David-Chadwick closed 10 months ago

David-Chadwick commented 11 months ago

Whilst the first tab of Example 1 (application/vc+ld+json) is correct, I do not believe that the third tab (application/vc+ld+json+sd-jw) is correct as it places the credentialSchema as a property of the credentialSubject

decentralgabe commented 10 months ago

I can't seem to find this. Maybe it has been fixed? Please let me know if you still see it.

David-Chadwick commented 10 months ago

This is because the second and third tabs have been removed from the example. I do not know which PR did this, but I would have thought that the correct approach was to fix the tabs rather than to remove them. Personally I found the tabs to be useful as they showed how the VC evolved to be a JWT

decentralgabe commented 10 months ago

@OR13 thoughts?

TallTed commented 10 months ago

[@David-Chadwick] the second and third tabs have been removed from the example

The tabs (both labels and content) of this example have been changed substantially, but I don't think anything has been removed. See the latest Editor's Draft.

Look particularly to where credentialSchema appears in what is now the fifth tab, now titled "Verified", which is part of what replaced what was in the third tab, then titled application/vc+ld+json+sd-jwt.

I believe that the concern about credentialSchema that @David-Chadwick raised in the initial comment here has been resolved.

David-Chadwick commented 10 months ago

The tabs have come back and now the content is correct, so this issue can be closed.

I suspect that @decentralgabe and myself viewed a temporary draft that was in the process of being fixed as a result of this issue (the first step being to remove wrong content, and the second step being to add the corrected content).