search

w3c / vc-jose-cose

Verifiable Credentials Working Group — VC JSON Web Tokens specification
https://w3c.github.io/vc-jose-cose/
Other
30 stars 9 forks source link

Remove duplicate descriptive language #183

Closed selfissued closed 9 months ago

selfissued commented 9 months ago

This removes duplicate language in the description of the use of JOSE header parameters and JWT claims. In the process, I moved the "JOSE Header Parameters" section before the "Key Discovery" section.

I added missing COSE content that corresponds to existing JOSE content.

I moved the "Wallets" section nearer to the end.

I believe that this is the last thing that we must do before submitting for CR.

Fixes #135

Preview | Diff

selfissued commented 9 months ago

@TallTed wrote:

the application/vp+ld+json+sd-jwt media type should not exist; this media type should be simply application/sd-jwt.

This PR does not change the media types in the specification, nor is it the right place to do so. Therefore, @TallTed, I'd ask you to withdraw your suggestions to change the media types here, since that's not the topic of the PR. If you want to discuss media types, I believe that issue #179 is already the right place to do so. Thanks.

OR13 commented 9 months ago

@TallTed I filed, https://github.com/w3c/vc-jose-cose/issues/184

to track your request to adjust the registration requests associated with typ.

lets get the argument for why you think that change should be made clearly captured there, and we will need to address it pre CR, I am going to resolve those suggestions for now.

OR13 commented 9 months ago

@TallTed I sent some emails to the relevant lists regarding your proposal, lets continue the media type parameter discussion on https://github.com/w3c/vc-jose-cose/issues/184.

Can you review again (assuming we will address 184 separately before CR) ?

Edit: I changed my mind, I think we need to address @TallTed 's comments in this PR, or at least have a path forward regarding profile and application/vc+... see https://github.com/w3c/vc-data-model/issues/1363

OR13 commented 9 months ago

After editors call, I agreed to address @TallTed 's feedback on typ in a separate PR, which is now up here: https://github.com/w3c/vc-jose-cose/pull/186

There will be merge conflicts, if this PR is merged, but I can address them, and https://github.com/w3c/vc-jose-cose/pull/186 makes it clear one way to resolve this issue.

OR13 commented 9 months ago

Open for a week, no objections, merging.