search

w3c / vc-jose-cose

Verifiable Credentials Working Group — VC JSON Web Tokens specification
https://w3c.github.io/vc-jose-cose/
Other
30 stars 9 forks source link

Add an example for selective disclosure #199

Closed decentralgabe closed 5 months ago

decentralgabe commented 8 months ago
  1. But the SD-JWT-VC IETF draft does specify selective disclosure in its title, even though it does not support W3C VCs. So by looking at the titles of both specs, readers will falsely think that the IETF draft is the only spec that supports W3C VCs and selective disclosure, and that our spec does not support it. This is obviously wrong, so we should try to help new readers who are presented with a list of titles to choose the correct standard.
  2. Sorry for the confusion, I am suggesting that the reference should be removed, not that we add text to reference it.

Handled in #198 #191

  1. Example 1 would be a good start. Perhaps a tab can be added to show the disclosures, or text could be added below the example to enumerate the disclosures.

To be handled

Originally posted by @David-Chadwick in https://github.com/w3c/vc-jose-cose/issues/191#issuecomment-1865028086

TallTed commented 8 months ago

Please edit initial comment and delete leading spaces, such that list item 1 is not presented as code. Should also make clear that items 1 and 2 were already addressed (in #198, partially handling #191), and item 3 is the remaining concern.

David-Chadwick commented 7 months ago

PR #215 addresses this issue for example 1. Another similar PR is also needed for example 2.

decentralgabe commented 6 months ago

This is completed

David-Chadwick commented 6 months ago

Half completed!!

decentralgabe commented 6 months ago

@David-Chadwick are you suggesting an example for SD-JWT-VC?

David-Chadwick commented 6 months ago

No, for the VP in example 2

TallTed commented 6 months ago

@decentralgabe — As @David-Chadwick said three weeks ago --

Another similar PR is also needed for example 2.

Please reopen this issue, and don't close it until example 2 is addressed.

decentralgabe commented 5 months ago

This was fixed by #241