w3c / vc-jose-cose

Verifiable Credentials Working Group — VC JSON Web Tokens specification
https://w3c.github.io/vc-jose-cose/
Other
30 stars 9 forks source link

Update Title #212

Closed David-Chadwick closed 7 months ago

David-Chadwick commented 7 months ago

The new title more accurately described the content of the specification


Preview | Diff

selfissued commented 7 months ago

If you'd like the working group to discuss this topic, please open an issue for the discussion. Before a PR is created, we normally first obtain working group consensus on any change to be made. Please close this PR until such time as there is working group consensus to make a change. Thank you.

David-Chadwick commented 7 months ago

this issue already exists. It is #201

iherman commented 7 months ago

Just a semi-admin comment: if the title changes, do we want to keep the short name of the spec, ie, vc-jose-cose? If we do, we will have to go through the administrative steps to change the short name in the W3C administration. We have done this before (including for this spec...); it is a pain in the back, but is of course doable.

decentralgabe commented 7 months ago

This should be closed until we have consensus in an issue.

TallTed commented 7 months ago

@David-Chadwick — You will generally get less pushback on a PR if you note that it (partially or fully) addresses an Issue, including that Issue's number/link, in the initial comment and/or title of a PR. This also helps all readers of the PR know what's going on, including checking the Issue for consensus (or lack thereof) more quickly.

That said, in my experience, drafting a PR (whether or not it's tagged as DRAFT in the GitHub systems) does not require prior consensus be reached on an Issue, and often helps groups reach that consensus, as it provides concrete text and other changes to consider.

David-Chadwick commented 7 months ago

@TallTed Thankyou. That was primarily my intention i.e. to get resolution and clarification of what this specification is actually about, as the current text is contradictory. The title and abstract say it is JOSE security for VCs whereas the introduction and body describe SD-JWT security. Thus my conclusion is that it is actually about securing VCs using SD-JWT.

decentralgabe commented 7 months ago

Closing, as we're headed in the direction of including all of JOSE.