search

w3c / vc-jose-cose

Verifiable Credentials Working Group — VC JSON Web Tokens specification
https://w3c.github.io/vc-jose-cose/
Other
30 stars 9 forks source link

Improving explanation of SD-JWT #215

Closed David-Chadwick closed 6 months ago

David-Chadwick commented 7 months ago

This adds clarifying text and further describes example 1 to the reader

Preview | Diff

selfissued commented 7 months ago

If you'd like the working group to discuss this topic, please open an issue for the discussion. Before a PR is created, we normally first obtain working group consensus on any change to be made. Please close this PR until such time as there is working group consensus to make a change. Thank you.

David-Chadwick commented 7 months ago

the issue is already there. It is #199 This is the PR to resolve it.

decentralgabe commented 7 months ago

Closing, as we're headed in the direction of including all of JOSE.

David-Chadwick commented 7 months ago

This PR should still be relevant when JOSE is added back, since what it does is describe the SD-JWT example. Unless the SD-JWT example is to be removed, then I would kindly ask you to re-open this PR.

decentralgabe commented 7 months ago

@David-Chadwick it appears that half the language is relevant and another half is not. Is your preference to amend this PR or work on a new one?

David-Chadwick commented 7 months ago

As discussed in one of our recent weekly calls, the script that produces the multi-tab format for SD-JWT is faulty (e.g. the Disclosed tab is faulty). So obviously the text that describes this tab is not correct. Once the script has been fixed and the tabs amended, then the PR can be updated to describe each of the tabs. I am happy to update the PR once the revised script is available.

decentralgabe commented 7 months ago

Ok, I don't know much about this script but I'm happy to re-open the PR until then.

decentralgabe commented 6 months ago

related to #214

decentralgabe commented 6 months ago

Closing this as it is superseded by #241