Closed decentralgabe closed 5 months ago
@iherman should be good now!
I think it would be a good idea to fix not just the example, but enhance the description/requirements too. because the text leading to the examples was not clear either.
Going to change two things:
The issue was discussed in a meeting on 2024-01-24
Updated as described. The first example will render using Orie's plugin and the second is the original example that will render as-is.
Separately I have opened this issue related to #214 which will fix how these examples get rendered. Should be good to merge on approval.
@iherman can you re-review?
@iherman this has to do with the rendering issue that we are working to fix. the first will be rendered with multiple tabs showing issued/signed/revealed/etc the second will appear as is. I'd prefer to merge this as the rendering fix is a parallel effort.
@iherman this has to do with the rendering issue that we are working to fix. the first will be rendered with multiple tabs showing issued/signed/revealed/etc the second will appear as is. I'd prefer to merge this as the rendering fix is a parallel effort.
Ok. But then we should probably wait with the merge of this PR to get #214 settled, so that we would get a full picture.
this will be rebased and merged after #241 which is blocked by #239
this has been fixed by https://github.com/w3c/vc-jose-cose/pull/241
Fix #217
Preview | Diff