search

w3c / vc-jose-cose

Verifiable Credentials Working Group — VC JSON Web Tokens specification
https://w3c.github.io/vc-jose-cose/
Other
30 stars 9 forks source link

Fix example 24 with enveloped credential #219

Closed decentralgabe closed 5 months ago

decentralgabe commented 7 months ago

Fix #217

Preview | Diff

decentralgabe commented 7 months ago

@iherman should be good now!

Sakurann commented 7 months ago

I think it would be a good idea to fix not just the example, but enhance the description/requirements too. because the text leading to the examples was not clear either.

decentralgabe commented 7 months ago

Going to change two things:

  1. Add an example of a secure enveloped credential presentation
  2. Add text / descriptions
  3. Make sure there are examples of SD JWTs with disclosures in the presentation
iherman commented 7 months ago

The issue was discussed in a meeting on 2024-01-24

View the transcript #### 1.1. Fix example 24 with enveloped credential (pr vc-jose-cose#219) _See github pull request [vc-jose-cose#219](https://github.com/w3c/vc-jose-cose/pull/219)._ **Brent Zundel:** Ivan has suggested changes on this one that I believe have been addressed. There's a suggestion from Kristina about enhancing the description. It looks like a straightforward editorial change. **Gabe Cohen:** I do agree with Kristina's comments that we need an additional example that shows a secured envelope's presentation and it's lacking some text. I will do that in this issue and I'll note that I'll add this information. **Brent Zundel:** Anything else on 219?
decentralgabe commented 6 months ago

Updated as described. The first example will render using Orie's plugin and the second is the original example that will render as-is.

Separately I have opened this issue related to #214 which will fix how these examples get rendered. Should be good to merge on approval.

brentzundel commented 6 months ago

@iherman can you re-review?

decentralgabe commented 6 months ago

@iherman this has to do with the rendering issue that we are working to fix. the first will be rendered with multiple tabs showing issued/signed/revealed/etc the second will appear as is. I'd prefer to merge this as the rendering fix is a parallel effort.

https://github.com/w3c/vc-jose-cose/issues/214

iherman commented 6 months ago

@iherman this has to do with the rendering issue that we are working to fix. the first will be rendered with multiple tabs showing issued/signed/revealed/etc the second will appear as is. I'd prefer to merge this as the rendering fix is a parallel effort.

Ok. But then we should probably wait with the merge of this PR to get #214 settled, so that we would get a full picture.

decentralgabe commented 6 months ago

this will be rebased and merged after #241 which is blocked by #239

decentralgabe commented 5 months ago

this has been fixed by https://github.com/w3c/vc-jose-cose/pull/241