search

w3c / vc-jose-cose

Verifiable Credentials Working Group — VC JSON Web Tokens specification
https://w3c.github.io/vc-jose-cose/
Other
31 stars 9 forks source link

Fix rendering of examples #237

Closed decentralgabe closed 5 months ago

decentralgabe commented 5 months ago

Have re-worked @OR13's plugin to get rid of the service worker approach and loading of local resources; switched to using a CDN which fixes the build issue.

There are further improvements to be made, but at least this will make published versions (on w3.org) consistent with w3c.github.io versions.

Preview | Diff

decentralgabe commented 5 months ago

Purely an example rendering changing, have editorial approval, merging.

David-Chadwick commented 4 months ago

As a matter of procedure, I think it was a bit rushed to merge this. The PR was issued on Friday evening, I was asked to review it but it was merged on Saturday before I had time to review on Monday morning.

decentralgabe commented 4 months ago

@David-Chadwick since the changes were purely related to examples and had editorial approval (and these changes are blocking multiple PRs) I opted to merge.

I appreciate and welcome your feedback, and am willing to incorporate it in follow-up changes. I have taken a note on renaming Disclosed to Credential. https://github.com/w3c/vc-jose-cose/issues/240