search

w3c / vc-jose-cose

Verifiable Credentials Working Group — VC JSON Web Tokens specification
https://w3c.github.io/vc-jose-cose/
Other
31 stars 9 forks source link

Add Securing with JWS #239

Closed selfissued closed 4 months ago

selfissued commented 4 months ago

Fixes #201

Preview | Diff

iherman commented 4 months ago

I may misunderstand something. But... on the examples 2 and 4, on the tab 'Verified', I miss the id value for the protected and enveloped verifiable credential. This id value, which is a data URL, should encode the credential itself. Compare to Example in the VCDM spec.

iherman commented 4 months ago

I think this was already mentioned elsewhere (@decentralgabe may remember): in Example 26 the list for verifiableCredential is erroneous. "Pure" URL-s may not appear there...

decentralgabe commented 4 months ago

@iherman I see what you're saying, there is an issue with our example rendering. @OR13 has graciously taken on some work to fix this, for which I have opened #240 to track this and referenced your issue.

I would ask that we view Mike's change set independent of the example rendering issues, which I will work to fix in the coming days.

brentzundel commented 4 months ago

I'm not sure I'll be a helpful reviewer until this PR is rebased on top of recent changes made in #231