search

w3c / vc-jose-cose

Verifiable Credentials Working Group — VC JSON Web Tokens specification
https://w3c.github.io/vc-jose-cose/
Other
31 stars 13 forks source link

Update example rendering for JOSE / COSE #240

Closed decentralgabe closed 7 months ago

decentralgabe commented 7 months ago 
          I suggest that the Disclosed tab should be renamed to Credential and be the first tab in the set, since this appears to be the raw credential before it undergoes any processing

Originally posted by @David-Chadwick in https://github.com/w3c/vc-jose-cose/pull/237#pullrequestreview-1888208624

Also the verified tab should correctly display enveloped credentials as per @iherman's comment here https://github.com/w3c/vc-jose-cose/pull/239#issuecomment-1953970067

decentralgabe commented 7 months ago

@David-Chadwick this should be fixed by uptaking @OR13's change set here https://github.com/transmute-industries/respec-vc-jwt/pull/5 which supports examples for more than SD-JWT.

I will make sure this gets done.

decentralgabe commented 7 months ago

flagging there are some comments from @TallTed here that I will include in this change set.

David-Chadwick commented 7 months ago

Thanks. Looking forward to reviewing the PR