search

w3c / vc-jose-cose

Verifiable Credentials Working Group — VC JSON Web Tokens specification
https://w3c.github.io/vc-jose-cose/
Other
31 stars 9 forks source link

Prepare Draft for CR #265

Closed decentralgabe closed 3 months ago

decentralgabe commented 3 months ago

Creates a CR draft whose date is set to April 18 2024. Updates the main draft to be for 'CR'. Exit date set 3 months after CR begins, to July 18 2024.

Preview | Diff

iherman commented 3 months ago

The Status section must include a text outlining the CR exit criteria. This is, for example, the text in the eddsa spec:

The Working Group is actively seeking implementation feedback for this specification. In order to exit the Candidate Recommendation phase, the Working Group has set the requirement of at least two independent implementations for each mandatory feature in the specification. For details on the conformance testing process, see the test suites listed in the implementation report.

This text could be taken over verbatim, except for the pointer to the implementation which must be adjusted.

Technically, this paragraph should be put into the status section (which will be completed by respec with the standard boilerplate as now).

(Github's review system did not allow me to propose changes on a content that was not changed; I would have done this myself...)

iherman commented 3 months ago

Another point: the 'exit' date (to be precise, the date before which we cannot publish a proposed rec) is at least 28 days after the publication. Ie, July 18 is way too much, I would propose to set it to May 18 (although it is not really important for us in practice, but it puts us in sync with the other documents).

iherman commented 3 months ago

I have run the document against the pubrules' and link checker. Pubrules are fine; link checker reports some errors, see below. I presume all these errors could be handled easily (find the right fragment ID); can you do that, please?

Broken fragments:
    https://www.w3.org/TR/vc-data-model-2.0/#securing-verifiable-credentials (lines 2610, 3990)
    https://www.w3.org/TR/vc-data-model-2.0/#proof-formats (line 2606)

---

Broken fragments:
    https://www.rfc-editor.org/rfc/rfc9052#section-3.1.1 (line 1851)

---

Broken fragments:
    https://w3c.github.io/vc-specs-dir/#proof (line 2444)
decentralgabe commented 3 months ago

thank you for the thorough review @iherman I believe I have addressed all comments and lints