search

w3c / vc-jose-cose

Verifiable Credentials Working Group — VC JSON Web Tokens specification
https://w3c.github.io/vc-jose-cose/
Other
31 stars 9 forks source link

Remove YAML; add disclosures to SD-JWT examples; add protected headers #272

Closed decentralgabe closed 2 months ago

decentralgabe commented 2 months ago

Fix #269 and replaces #270 Fix #271

Does not yet address #264 which I will take in a subsequent PR to add multiple tabs to the standalone SD-JWT example

for the combined example I feel this would be too much to display

Preview | Diff

bc-pi commented 2 months ago

Not sure if/how to comment here but from a quick look at the Preview the examples don't look to be self consistent or syntactically correct.

decentralgabe commented 2 months ago

@bc-pi I see some issues too, I'll fix them and comment here when they're addressed.

decentralgabe commented 2 months ago

@bc-pi it's rare I screw up so bad I leave someone speechless 😂 - my apologies

I've fixed the code, if you refresh https://pr-preview.s3.amazonaws.com/w3c/vc-jose-cose/pull/272.html you'll see it in a better state. I may have to do some work on the nested disclosures, though I still believe this is an improvement.

Hopefully it's at least to a place where you can articulate what's still not right.

decentralgabe commented 2 months ago

https://github.com/w3c/vc-jose-cose/pull/273 going to close and re-open ... rendering is not working as expected