search

w3c / vc-jose-cose

Verifiable Credentials Working Group — VC JSON Web Tokens specification
https://w3c.github.io/vc-jose-cose/
Other
31 stars 13 forks source link

(English) references to the VCDM spec are wrong in the 1.1 section #66

Closed iherman closed 1 year ago

iherman commented 1 year ago

Provided that the answer to the question in #65 is that the 1.1 section should be left in the spec (albeit updated), there are a number of references to the VCDM which are wrong. For example, §2.2.1 starts with

To encode a verifiable credential as a JWT, specific properties introduced by this specification MUST be either:

but the English references "by this specification" is wrong: it should be replaced by a reference to the VCDM spec. This is an obvious leftover of the fact that this part of the spec was copy pasted from the VCDM 1.1 document. The whole §2.2 section should be revised in this respect. This must be done, in my view, before this document is published as a FPWD.

TallTed commented 1 year ago

This must be done, in my view, before this document is published as a FPWD.

It will cause no harm to publish FPWD before this (known issue, tracked here) is fixed.

OR13 commented 1 year ago

I have started to address this in https://github.com/w3c/vc-jwt/pull/68

It will probably take a few passes to make these sections read smoother.

OR13 commented 1 year ago

This issue is stale and should be closed.

OR13 commented 1 year ago

Marked pending close over 1 week ago, closing.