w3c / vc-json-schema

A mechanism to use JSON Schemas with Verifiable Credentials
https://w3c.github.io/vc-json-schema
Other
27 stars 8 forks source link

Renamed `name` to `title` and added `lang` & `dir`. #225

Closed andresuribe87 closed 1 year ago

andresuribe87 commented 1 year ago

Fixes #224 by adding a locale field.

Additionally, this PR also renames name in favor of title, because the latter is part of the json schema spec.


Preview | Diff

aphillips commented 1 year ago

"locale" is probably not the right name for this field, as it implies something about the processing environment or maybe the configuration of the host serving the credentials.

A better model would probably be to follow some other specs and use lang/dir (one example: app-manifest lang and app-manifest dir) for the document-wide language and direction.

Providing for multilingual title and description would be up to your WG. It's not that uncommon to want labels in two or three languages. But it's not a blocker for getting your spec out the door.

andresuribe87 commented 1 year ago

Thanks @aphillips , I made the changes so we use lang and dir in a similar way.