search

w3c / vc-jws-2020

Verifiable Credentials Working Group — JSON Web Signature 2020 specification
https://w3c.github.io/vc-jws-2020/
Other
5 stars 1 forks source link

Add IANA to context #24

Closed OR13 closed 1 year ago

OR13 commented 2 years ago

Example:

https://v.jsld.org/GDSUfCu8czkBP5Bt7o84LYB6vAgf2PZTxAK1dQeeeZXNEJQ8Rs1HWUm6EkGLvfGocoNo2WggVub7qiZsymP15MZsq3f3ARsALtcEWvehEMcdwHk1tVWJMPdG8uFp7uefv1SkpPmCwekrmmWME7XJasmLspHyja2VaBgwQRHi2szQobcHJP5TyEYNhKpysjv4m95whubPpKbQ39or9MiuGFnLGrYprzFX1VBeqfyWadnpHL6H6FhsFnQurDBKfqqDqvANSLr664GGZQ67MFXTyRRmZkEdnT3oA7t7wqPrdBzzDnrP86XxaWJ4bXJ9yTATKNDJbho7kV5PNj2goybwDMjDk8FqmTvLrwyDUJWeifynJu8iEYkgMi8CWCUg8vWJybKdNQn23YN6W4MCvUdfuTdnPLYmSw1Ph6u7nRdJ9QBDqShmbZ6nBiBELnwkkpc2NB1B3qvK1RL2SjbisiCWbTkwZpudxUrYJU9daw6rvhMbZYQivoKENAWWYEhoFtuo18UXDzKcyP4Q9Qm3rcGg3jMRckTYCFqo1PCNdYQHsjqUnB9sMUx9WKLHtWTUXkGwEJAm8TibEigPwH4YakJVCZJhy2qwmiXNXwVBgsnk7WJGeG7dnihnczQ2XKAv16CyeGuVyqWxRP7kTF7ur1pfit7TsvJkwAUoptJUexsEdYeiAswJFvhZUgTLXjNk8YbyJBH6s5JRJjmfamD5t9XN45FVCDxtNjNhawbagi59NKeQMMPRWR3myhm9P8Z2hBbLvfAGL2PgRvHic1W2gRr6qVc5LTUawg28zHQGRQTtsTXtjdBjV1QreHKqkVUNuUcNDgufe6p2g3xasHU677TerwqC7bWh3R1N2mUaG3Cxoh7tdPFUJ2zm7KvRzPgpcv6KvpiLAiUVX6NR1UUPnvEEHkcSUcmq7VLhMFq25dPABKxZFa8Wbf8tiTbSZBY9DqWr1iHyX5BYy2SkCBTaGPtYAicnKJQQascuFdvChu5qtHu2C7Ek

<did:key:zDnaeXdW4RWTECx6oQUdsKFeA2mFSukLZqMut4k2fNGD5zRvR#zDnaeXdW4RWTECx6oQUdsKFeA2mFSukLZqMut4k2fNGD5zRvR> <https://w3id.org/security#publicKeyJwk> _:c14n0 .
_:c14n0 <https://www.iana.org/assignments/jose/jose.xhtml#crv> "P-256" .
_:c14n0 <https://www.iana.org/assignments/jose/jose.xhtml#kty> "EC" .
_:c14n0 <https://www.iana.org/assignments/jose/jose.xhtml#x> "avZDvl0UJ8m2ALyyYH4C1rDFRtGrYVR_k5Vxf3I0gGI" .
_:c14n0 <https://www.iana.org/assignments/jose/jose.xhtml#y> "9Gf32bd7YZwirWBYgB4losRZ-qKuB2liexbCpl1rBBw" .
iherman commented 2 years ago

The issue was discussed in a meeting on 2022-08-31

View the transcript #### 4.1. Add IANA to context (pr vc-jws-2020#24) _See github pull request [vc-jws-2020#24](https://github.com/w3c/vc-jws-2020/pull/24)._ **Antony Nadalin:** We're not changing the vocabulary of what JWS/JWT use today, correct?. **Orie Steele:** No, we are not changing that, I don't think. There are certain terms that need to be defined to make a Data Integrity Proof valid, I'm intending those terms to be defined by IANA. If folks don't agree that IANA is the right one, for example citing the RFCs directly, we can have that conversation if folks want to do that..
mprorock commented 2 years ago

+1 to using @vocab in this context to point back at jose

iherman commented 2 years ago

The issue was discussed in a meeting on 2022-10-05

View the transcript #### 1.4. JWS 2020 _See github pull request [vc-jws-2020#24](https://github.com/w3c/vc-jws-2020/pull/24)._ **Orie Steele:** JWS2020 has one open PR, call to get reviews. … Ready to kick off FPWG process with guidance. **Ivan Herman:** synchronizing publication with other work items, including data integrity, may make things simpler. **Manu Sporny:** +1, we don't have to time all of them together, VC-JWT is separate, Data Integrity and JWS2020 can be done at the same time.
msporny commented 2 years ago

I am requesting changes and objecting to merging this PR because of the use of @vocab, please use fully qualified URLs for terms. Please add @protected term on the term definition.

iherman commented 2 years ago

The issue was discussed in a meeting on 2022-10-19

View the transcript #### 2.7. Add IANA to context (pr vc-jws-2020#24) _See github pull request [vc-jws-2020#24](https://github.com/w3c/vc-jws-2020/pull/24)._ **Orie Steele:** no changes requested for this. **Manu Sporny:** there is an objection. … use fully qualified URLs. **Orie Steele:** please make it clear what change you request. **Dave Longley:** I also have a change request. **Orie Steele:** this pull request is trying to point to IANA for term definitions. … IANA is required to maintain these registeries rather than a community group re-direction service. … concern is if people add their own terms which are not defined in IANA. … but if they get widely used then they are usually eventually registered. … sometimes we use an algorithm name but then stop using it and it does not get registered. … because it is superceded and the new term gets registered at IANA. **Manu Sporny:** biggest issue is the use of vocabulary. With this PR we are saying you can put anything into a JWK which will be in the IANA registry. … when we are doing crypto we should be very specific with our terms so there is no ambiguity. … The alternative is if the PR said which parts of the JOSE registry we are using, and is precise, without including everything.. … because the way the PR is now you can use prohibited terms and terms that are not defined. > *Orie Steele:* Please make sure to put your concrete change suggestions on the PR and request changes, so I can address each of them individually.. > *Manu Sporny:* Sure thing.. > *Manu Sporny:* Though, I did just elaborate on them here, in the minutes, which should be included in the PR.
dlongley commented 2 years ago

@peacekeeper,

Is there a risk that a conflict may arise, if these are defined differently here and in DID Core? Or is such conflict avoided by the fact that they are defined as scoped terms here?

As long as the scopes don't overlap (such that two different definitions come into scope concurrently), there shouldn't be a conflict. However, I would recommend that the definitions remain the same to avoid any potential for unforeseen conflict. I don't think it buys us anything to change them; it only adds risk that someone might try to use both definitions in the same place and not be able to because of unnecessary differences.

OR13 commented 1 year ago

This pull request is over taken by comments on https://github.com/w3c/vc-data-model/issues/953

I suggest we leave this open until that issue is resolved.

iherman commented 1 year ago

The issue was discussed in a meeting on 2022-11-02

View the transcript #### 1.7. Add IANA to context (pr vc-jws-2020#24) _See github pull request [vc-jws-2020#24](https://github.com/w3c/vc-jws-2020/pull/24)._ **Orie Steele:** other issue is PR 24. … this one is regarding context. … overtaken by massive amount of comments on @context discussion. … please give comments on PR 24 but we have to wait for `@context` discussion. **Manu Sporny:** comments on future work items. … CCG has prepared VC API to be published as a note. … in coming weeks. … other final report published through CCG that built on top of data integrity. … docs are currently prepared. … ECDSA and Edwards curve signature suites. … in coming weeks as well. > *Michael Prorock:* +1 manu - chairs at CCG will be on lookout. **Brent Zundel:** moving to issue discussion.
iherman commented 1 year ago

The issue was discussed in a meeting on 2022-11-30

View the transcript #### 2.3. Add IANA to context (pr vc-jws-2020#24) _See github pull request [vc-jws-2020#24](https://github.com/w3c/vc-jws-2020/pull/24)._ **Orie Steele:** encourage wg members to review and add comments/questions/suggestions; what role does W3C have in relation to work items outside of W3C?. **Ivan Herman:** reached out to W3C re the FPWD publication of JWS-2020.
OR13 commented 1 year ago

Closing this pending the resolution of https://github.com/w3c/vc-data-model/issues/947