search

w3c / vc-test-suite

Verifiable Credentials WG Test Suite
https://w3c.github.io/vc-test-suite/
BSD 3-Clause "New" or "Revised" License
69 stars 39 forks source link

Use URI for refreshService id #123

Open clehner opened 2 years ago

clehner commented 2 years ago

Change test title to use URI instead of URL.

The old test is added to the list of deprecated tests so that it no longer appears in the results.

Corresponds to https://github.com/w3c/vc-data-model/pull/819

TallTed commented 2 years ago

One file now requires URI, the other now requires URL. These should be the same. (Whether they should both be URI or URL seems to be currently being debated in other issues.)

clehner commented 2 years ago

@TallTed I'm not sure what you mean. Which files?

iherman commented 2 years ago

The issue was discussed in a meeting on 2022-02-09

View the transcript #### 4.1. [Tracking Issue - Proposed Corrections Feedback] Test suite improvements are needed (issue vc-test-suite#126) _See github issue [vc-test-suite#126](https://github.com/w3c/vc-test-suite/issues/126)._ **Charles Lehner:** Tallted has commented on this. > *Charles Lehner:* See [Ted's comments](https://github.com/w3c/vc-test-suite/pull/123#discussion_r800718574). _See github pull request [vc-test-suite#123](https://github.com/w3c/vc-test-suite/pull/123)._ **Charles Lehner:** when a test has not been evaluated or when feature did not previously exist, I still need to respond to TallTed. _See github pull request [vc-test-suite#127](https://github.com/w3c/vc-test-suite/pull/127)._ **Brent Zundel:** is there anyone on the call that can review these?. **Manu Sporny:** you can add me. … we did not copy 1.0 test suite to a new one. Instead we should add tests to the 1.0 test suite. … this will not require testers to re-run all their previous tests. … there will be a proposal to change the way we run tests for v2.0.