search

w3c / vc-test-suite

Verifiable Credentials WG Test Suite
https://w3c.github.io/vc-test-suite/
BSD 3-Clause "New" or "Revised" License
69 stars 39 forks source link

Update ZKP tests for changes in VC Data Model v1.1 #127

Open clehner opened 2 years ago

clehner commented 2 years ago

Update the test suite to correspond with changes in https://github.com/w3c/vc-data-model/pull/818 to normatives statements about ZKPs.

I added the skipped tests as I am not sure how to test those. Possibly the one about credentialSchema could be addressed with a new optional section to test ZKP types that require credentialSchema. But there is already a section testing credentialSchema. Several tests related to credentialSchema are removed from the ZKP section, but similar tests are still present in the credentialSchema section (test/vc-data-model-1.0/20-schema.js).

The requirement that a verifiable credential "MUST contain all information necessary to verify..." could perhaps be tested with a contrived example where the signature input contains some data not present in the verifiable credential. But I don't know if that is representable in the VC Data Model.

iherman commented 2 years ago

The issue was discussed in a meeting on 2022-02-09

View the transcript #### 4.1. [Tracking Issue - Proposed Corrections Feedback] Test suite improvements are needed (issue vc-test-suite#126) _See github issue [vc-test-suite#126](https://github.com/w3c/vc-test-suite/issues/126)._ **Charles Lehner:** Tallted has commented on this. > *Charles Lehner:* See [Ted's comments](https://github.com/w3c/vc-test-suite/pull/123#discussion_r800718574). _See github pull request [vc-test-suite#123](https://github.com/w3c/vc-test-suite/pull/123)._ **Charles Lehner:** when a test has not been evaluated or when feature did not previously exist, I still need to respond to TallTed. _See github pull request [vc-test-suite#127](https://github.com/w3c/vc-test-suite/pull/127)._ **Brent Zundel:** is there anyone on the call that can review these?. **Manu Sporny:** you can add me. … we did not copy 1.0 test suite to a new one. Instead we should add tests to the 1.0 test suite. … this will not require testers to re-run all their previous tests. … there will be a proposal to change the way we run tests for v2.0.
clehner commented 2 years ago

The comment as it is now uses the wording from VC Data Model: https://www.w3.org/TR/vc-data-model/#zero-knowledge-proofs

Maybe it is better to keep it the same, so it is easier to find the correspondence with the spec? Or do you think it should be changed in vc-data-model as well?