added support for JWT test cases support

w3c / vc-test-suite

Verifiable Credentials WG Test Suite

https://w3c.github.io/vc-test-suite/

BSD 3-Clause "New" or "Revised" License

68 stars 39 forks source link

added support for JWT test cases support #50

Closed awoie closed 5 years ago

awoie commented 5 years ago

added support for JWT test cases support

according to sequence diagram in assets folder
50-jwt.js now tests VC spec JWT MUST statements
config.json.jwt.example shows command line options for JWT generators

awoie commented 5 years ago

@dmitrizagidulin could you please review to allow us and others to upload test reports on time :)

TallTed commented 5 years ago

We've still got problems with nbf ("Not Before", the actual semantic intent of issuanceDate) vs iat ("Issued At", the incorrect but closest simple-language match).

(Double problems, as I think these tests now match the spec as it stands, but the spec needs to be corrected, and the tests need to be corrected to match.)

stonematt commented 5 years ago

Pull this PR in after the switch to the nbf claim type

dmitrizagidulin commented 5 years ago

@awoie Thanks! (Do you mind rebasing on latest, to remove the conflict?)

awoie commented 5 years ago

pr should be fine now (rebased) and contains the nbf change @dmitrizagidulin @TallTed

awoie commented 5 years ago

@dmitrizagidulin is there any chance of getting this PR in this week? (i don't have permissions to assign reviewers or do other things in this repo)